Merged
Conversation
atlStr.h is not part of VS2013 - but should be part of the new Windows SDK 8.1. Though it doesn't seem to be used. Changed the includes to be standard, like the other projects: DummyDevice, OniFile, PS1080, PSLink, TestDevice
jrpowers
added a commit
that referenced
this pull request
May 5, 2014
Make compatible with VS2013 express and remove unnecessary include.
|
Hello @larshg. The pull requests you submitted today were breaking builds made using previous versions of Visual Studio. I just fixed that on the develop branch. Can you please pull it and let us know if things still work for you? Thanks! |
Author
|
Hi @ntisserand It works fine - and I can see you changed a few project properties, that I was wondering if I should have changed too. About the safeseh property - so thats nice :) Regards, Lars |
Windowsfreak
added a commit
to Windowsfreak/OpenNI2
that referenced
this pull request
Feb 19, 2015
List.add(object) returns boolean, not void! See http://stackoverflow.com/a/17297094 Not changing this causes the following error: 02-17 20:06:09.617 W/dalvikvm(4962): JNI WARNING: expected return type 'V' 02-17 20:06:09.617 W/dalvikvm(4962): calling Ljava/util/List;.add (Ljava/lang/Object;)Z 02-17 20:06:09.617 W/dalvikvm(4962): in Lorg/openni/NativeMethods;.oniGetDeviceList:(Ljava/util/List;)I (CallVoidMethodV) with the stack 02-17 20:06:09.632 I/dalvikvm(4962): structureio#6 pc 00002a58 /system/lib/libOpenNI2.jni.so (_JNIEnv::CallVoidMethod(_jobject, _jmethodID, ...)+15) 02-17 20:06:09.632 I/dalvikvm(4962): structureio#7 pc 00003b88 /system/lib/libOpenNI2.jni.so (Java_org_openni_NativeMethods_oniGetDeviceList+179)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed include for Devices/Kinect project to match the others - as it gave include errors.
Removed atlstr.h, as it is not part of VS2013 express - and doesn't seem to be used.