Skip to content

update!: changed APIs of Err, etc. according with sttk-go/sabi #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sttk merged 1 commit into from
May 1, 2023
Merged

update!: changed APIs of Err, etc. according with sttk-go/sabi #13

sttk merged 1 commit into from
May 1, 2023

Conversation

@sttk
Copy link
Owner

@sttk sttk commented May 1, 2023

This PR changes APIs of Err, ErrHandler, and ErrNotifier, according with sttk-go/sabi.

  • Access modifiers of Err#getFileName and Err#getLineNumber are changed from public to protected.
  • Err.addSyncHandler, Err. addAsyncHandler, and Err.sealErrCfgs are renamed to Err.addSyncErrHandler, Err. addAsyncErrHandler, and Err.fixErrCfgs.
  • Argument composition of ErrHandler#handle are changed from (Err, OffsetDateTime) to (Err, ErrOccasion).

@sttk sttk merged commit 123dfe5 into main May 1, 2023
@sttk sttk deleted the update-change_apis_of_err_etc branch May 1, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sttk