Skip to content

suggester: fix existence check #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ngalaiko merged 1 commit into from
Aug 18, 2022
Merged

suggester: fix existence check #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/suggester/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,10 @@ const suggestViaGitHub = async ({

const alreadyExists = existingComments.some(comment => {
const isSameBody = comment.body === request.body
const isSameStartLineLine = comment.start_line === request.start_line
// NOTE: == is intentional, we want to treat undefined and null as equal
const isSameStartLine = comment.start_line == request.start_line
const isSameEndLine = comment.line === request.line
const isSame = isSameBody && isSameStartLineLine && isSameEndLine
const isSame = isSameBody && isSameStartLine && isSameEndLine
return isSame
})

Expand Down