Skip to content

Conversation

@jblueh
Copy link
Collaborator

@jblueh jblueh commented Jun 22, 2023

Overview

This PR provides a container that can be used for building SU2 with the thread sanitizer. Further steps would be a container for testing with the thread sanitizer, and ultimately running thread sanitizer tests as a part of SU2's CI pipeline. This is work in progress and there are things that need testing, hence the focus on the build container for now.

  1. Regarding the workflow in this repo that builds and uploads container images, do the resources of the CI pipeline suffice? The container involves building gcc from source, which does take some time.
  2. The existing build container and the new build container have common parts, when we know that everything works we could consider unifying them.

Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add this to the actions https://github.com/su2code/Docker-Builds/blob/master/.github/workflows/docker-image-upload.yml
So that we know whether it builds and uploads fine? Then it would be easy to use in our tests.

@jblueh
Copy link
Collaborator Author

jblueh commented Jun 23, 2023

Do you want to add this to the actions https://github.com/su2code/Docker-Builds/blob/master/.github/workflows/docker-image-upload.yml So that we know whether it builds and uploads fine? Then it would be easy to use in our tests.

Yes, I will add it.

@jblueh jblueh changed the title [WIP] Add container for building SU2 with the thread sanitizer Add containers for building and testing SU2 with the thread sanitizer Jun 23, 2023
@jblueh
Copy link
Collaborator Author

jblueh commented Jun 23, 2023

Should I go ahead and merge to trigger the pipeline?

@pcarruscag
Copy link
Member

Yeah go for it

@jblueh jblueh merged commit cf09a7a into master Jun 23, 2023
@jblueh jblueh deleted the feature_tsan branch June 23, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants