-
Notifications
You must be signed in to change notification settings - Fork 913
change kind_solver option to enum class #1451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have now added defaults to all getkind_solver switches: the first objective here is to pass the regression tests. It still has to be checked if we need to add solver switches, or throw an error if for some reason we end up in the default switch. |
TobiKattmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this big chungus
Co-authored-by: TobiKattmann <31306376+TobiKattmann@users.noreply.github.com>
…into feature_enumsolver
Co-authored-by: TobiKattmann <31306376+TobiKattmann@users.noreply.github.com>
…into feature_enumsolver
TobiKattmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💐 LGTM. Again, thanks for this
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Proposed Changes
Give a brief overview of your contribution here in a few sentences.
make kind_solver an enum class
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
continuing work on making enums into enum classes
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.