Skip to content

Conversation

@bigfooted
Copy link
Contributor

Proposed Changes

Give a brief overview of your contribution here in a few sentences.
make kind_solver an enum class

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
continuing work on making enums into enum classes

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • [x ] I am submitting my contribution to the develop branch.
  • [x ] My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • [ x] My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

@bigfooted
Copy link
Contributor Author

I have now added defaults to all getkind_solver switches: the first objective here is to pass the regression tests. It still has to be checked if we need to add solver switches, or throw an error if for some reason we end up in the default switch.

Copy link
Contributor

@TobiKattmann TobiKattmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this big chungus

@bigfooted bigfooted changed the title [WIP] changed kind_solver option to enum class change kind_solver option to enum class Nov 26, 2021
Copy link
Contributor

@TobiKattmann TobiKattmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💐 LGTM. Again, thanks for this

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
@bigfooted bigfooted merged commit acb75bd into su2code:develop Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants