Skip to content

Conversation

@MicK7
Copy link
Contributor

@MicK7 MicK7 commented Jan 4, 2022

CGNS file older than 4.0 release have a high ram memory usage

Proposed Changes

Add a small message to help users understand that SU2 is eating their RAM with old CGNS files.

Related Work

See: #1378

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

CGNS file older than 4.0 release have a high ram memory usage
@pcarruscag pcarruscag changed the title Inform user of possible memory issue Inform user of possible CGNS memory usage issue Jan 4, 2022
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
@MicK7
Copy link
Contributor Author

MicK7 commented Jan 4, 2022

@pcarruscag Thanks for the review

@MicK7 MicK7 merged commit cdf780a into develop Jan 4, 2022
@MicK7 MicK7 deleted the warns_for_cgns_memory_issue branch January 4, 2022 19:19
@TobiKattmann
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants