Fix implicit call for NEMO cases #1482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WallyMaier
commented
Jan 7, 2022
|
|
||
| /*--- Read from CConfig ---*/ | ||
| implicit = (config->GetKind_TimeIntScheme() == EULER_IMPLICIT); | ||
| implicit = (config->GetKind_TimeIntScheme_Flow() == EULER_IMPLICIT); |
Contributor
Author
There was a problem hiding this comment.
This is always true for at least the first iteration.
Member
There was a problem hiding this comment.
Yep you need the physics specific versions (_Flow, _Turb, etc.) in constructors.
Contributor
Author
|
@CatarinaGarbacz please let me know if this fix resolves your issues. |
pcarruscag
approved these changes
Jan 7, 2022
TobiKattmann
approved these changes
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This changes a boolean check in CNEMONumerics.cpp which always seems to be true. This has been causing some segfaults in 10-11 species viscous cases. I suspect this is causes because the Kind_TimeNumScheme is not updated before the numerics constructor.
Some work that still needs to be done is confirm/test 10 and 11 species gases do work when the problem is supposed implicit.
Related Work
PR#1422
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.