Skip to content

Conversation

@pcarruscag
Copy link
Member

Small change for consistency with work done in #1552 to address #1493
Useful at least to get all the residuals with little work...

@pcarruscag pcarruscag changed the title Allow groups in SCREEN_OUTPUT Allow field groups in SCREEN_OUTPUT (e.g. RMS_RES like for HISTORY_OUTPUT) Mar 31, 2022
@lgtm-com
Copy link

lgtm-com bot commented Apr 1, 2022

This pull request fixes 5 alerts when merging 525ce91 into c204683 - view on LGTM.com

fixed alerts:

  • 5 for Comparison of narrow type with wide type in loop condition

Copy link
Contributor

@TobiKattmann TobiKattmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Love it 💐 I tend to write every RMS, so this will ease things a bit. I guess this also works for adjoint cases which is one thing less to care about in a setup 👍

https://github.com/su2code/SU2/pull/1571/files#diff-7d139cfb7a735e5c085a26f115306f13b8209745edf69dc56281269478784972 from #1571 would be a nice application as it would cover a primal and an adjoint case (momentum residuals are not present in the current setup though)

(I guess the order of RMS is changed for your adapted testcase: Now it is rho, rhoE, rhoU, rhoV instead of rho, rhoU, rhoV, rhoE ... but no values changed)

@lgtm-com
Copy link

lgtm-com bot commented Apr 1, 2022

This pull request fixes 5 alerts when merging d8b83f3 into c204683 - view on LGTM.com

fixed alerts:

  • 5 for Comparison of narrow type with wide type in loop condition

Copy link
Contributor

@bigfooted bigfooted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, thanks for the follow up!

@pcarruscag pcarruscag merged commit 76d1ef2 into develop Apr 2, 2022
@pcarruscag pcarruscag deleted the allow_groups_for_screen_output branch April 2, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants