-
Notifications
You must be signed in to change notification settings - Fork 913
Allow field groups in SCREEN_OUTPUT (e.g. RMS_RES like for HISTORY_OUTPUT) #1587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request fixes 5 alerts when merging 525ce91 into c204683 - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Love it 💐 I tend to write every RMS, so this will ease things a bit. I guess this also works for adjoint cases which is one thing less to care about in a setup 👍
https://github.com/su2code/SU2/pull/1571/files#diff-7d139cfb7a735e5c085a26f115306f13b8209745edf69dc56281269478784972 from #1571 would be a nice application as it would cover a primal and an adjoint case (momentum residuals are not present in the current setup though)
(I guess the order of RMS is changed for your adapted testcase: Now it is rho, rhoE, rhoU, rhoV instead of rho, rhoU, rhoV, rhoE ... but no values changed)
…u2code/SU2 into allow_groups_for_screen_output
|
This pull request fixes 5 alerts when merging d8b83f3 into c204683 - view on LGTM.com fixed alerts:
|
bigfooted
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work, thanks for the follow up!
Small change for consistency with work done in #1552 to address #1493
Useful at least to get all the residuals with little work...