Fix running averages for restarted simulations #1601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When restarted at e.g. Time-Iter 2 the first value would be divided by 3 (number of timesteps counting from zero).
So if your first value in that restarted sim is a 3, the running average would be 1.
This is fixed with this commit by setting WINDOW_START_ITER = RESTART_ITER in the Config Postprocessing,
if the option is not set. If the option is set, but incorrectly, an error is raised.
Related Work
Original implementation #836
Change in previous behavior introduced in #1548
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.