Skip to content

Conversation

@TobiKattmann
Copy link
Contributor

@TobiKattmann TobiKattmann commented Apr 11, 2022

Hi,

When restarted at e.g. Time-Iter 2 the first value would be divided by 3 (number of timesteps counting from zero).
So if your first value in that restarted sim is a 3, the running average would be 1.

This is fixed with this commit by setting WINDOW_START_ITER = RESTART_ITER in the Config Postprocessing,
if the option is not set. If the option is set, but incorrectly, an error is raised.

Related Work

Original implementation #836
Change in previous behavior introduced in #1548

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

When restarted at e.g. Time-Iter 2 the first value would be divided by 3 (number of timesteps counting from zero).
So if your first value in that restarted sim is a 3, the running average would be 1.

This is fixed with this commit by setting WINDOW_START_ITER = RESTART_ITER in the Config Postprocessing,
if the option is not set. If the option is set, but incorrectly, an error is raised.
Tiny change to exactly have the github worklfow values
@TobiKattmann
Copy link
Contributor Author

Thanks for the review :) Once the tests pass with this tiny commited regression value change for the hybrid case - I'll merge this in

@pcarruscag
Copy link
Member

Sounds good thanks for the fix.

@TobiKattmann TobiKattmann merged commit 0f4339c into develop Apr 12, 2022
@TobiKattmann TobiKattmann deleted the fix_running_avg branch April 12, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants