Skip to content

Run the unsteady NACA0012 tutorial for 20 timesteps #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pcarruscag merged 4 commits into from
May 10, 2022
Merged

Run the unsteady NACA0012 tutorial for 20 timesteps #1616

pcarruscag merged 4 commits into from
May 10, 2022

Conversation

@pcarruscag
Copy link
Member

@pcarruscag pcarruscag commented Apr 23, 2022 •
edited
Loading

Starts to address #1604
The adjoint will be more work.
Depends on su2code/Tutorials#22

@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2022

This pull request fixes 3 alerts when merging cd5c18f into f4f6298 - view on LGTM.com

fixed alerts:

  • 3 for Comparison of narrow type with wide type in loop condition

pcarruscag
pcarruscag commented Apr 23, 2022
View reviewed changes
@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2022

This pull request fixes 3 alerts when merging 5674c23 into f4f6298 - view on LGTM.com

fixed alerts:

  • 3 for Comparison of narrow type with wide type in loop condition

TobiKattmann
TobiKattmann approved these changes Apr 23, 2022
View reviewed changes
Copy link
Contributor

@TobiKattmann TobiKattmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this Tutorial work nicely again and the additional cleanup on the output stuff 💐 Everything lgtm so feel free to merge this and the Tutorial PR from my side

pcarruscag
pcarruscag commented May 10, 2022
View reviewed changes
@pcarruscag pcarruscag merged commit fa910a0 into develop May 10, 2022
@pcarruscag pcarruscag deleted the improve_unsteady_tutorials branch May 10, 2022 01:24
@lgtm-com
Copy link

lgtm-com bot commented May 10, 2022

This pull request fixes 3 alerts when merging 3fa0e2a into 6acc62f - view on LGTM.com

fixed alerts:

  • 3 for Comparison of narrow type with wide type in loop condition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TobiKattmann TobiKattmann TobiKattmann approved these changes

Assignees

No one assigned

Labels

changelog:chore PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pcarruscag @TobiKattmann