Skip to content

Conversation

@bigfooted
Copy link
Contributor

Proposed Changes

Give a brief overview of your contribution here in a few sentences.
INCINLET_USENORMALS= YES will use the normals of the inlet boundary faces instead of the normal from MARKER_INLET.
This was only active for pressure inlets and not for velocity inlets.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

@pcarruscag
Copy link
Member

Please give this a more descriptive title, they show up in the change log of each version

@bigfooted bigfooted changed the title [WIP] fix for incinlet_usenormals [WIP] INCINLET_USENORMALS uses normal of inlet boundary for velocity inlets in addition to pressure inlets May 22, 2022
@bigfooted bigfooted changed the title [WIP] INCINLET_USENORMALS uses normal of inlet boundary for velocity inlets in addition to pressure inlets INCINLET_USENORMALS uses normal of inlet boundary for velocity inlets in addition to pressure inlets May 23, 2022
@bigfooted bigfooted merged commit 7a57336 into develop May 23, 2022
@bigfooted bigfooted deleted the feature_bugfix_incvel_usenormals branch May 23, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants