-
Notifications
You must be signed in to change notification settings - Fork 913
Add Heat Flux values to some regressions #1698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| OUTPUT_WRT_FREQ= 1000 | ||
| % | ||
| % Screen output | ||
| SCREEN_OUTPUT= (TIME_ITER, INNER_ITER, RMS_DENSITY, RMS_NU_TILDE, LIFT, DRAG) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the TIME_ITER to help with the regression scripts. Though the "SIM_VALUES" that are used in the regression don't seem to be the final simulation residual/coefficient values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That may not be ideal, without time iter the script will look at time step 0, we should test more than that.
With time iter it will look at the first inner iteration for the timestep you want.
|
@pcarruscag @martin-g I'm not sure how the regressions should run using the AARCH64 tests. I made some changes, but everything is still passing. |
|
@pcarruscag I'm noticing some strange behavior with regressions. Mainly the dicrete_adjoint_axisymmetric_rans case, which I only added a screen output field and the discrete_adj_transonic_rotor which I didnt touch. |
|
Looks like the stator was just the intermittent hybrid AD problem that is being worked on. So before the case was not testing anything 🤷 you have my blessing to do whatever you want, check if the new adjoints make some sense and update (good samaritan option), or blindly update, or don't modify the case, or delete it, up to you :) |
|
I have updated the discrete adjoint axisymmetric rans case regression values to match and pass. After trying to run the case, I noticed two things: |
Proposed Changes
This PR will add heat flux to the values that are checked in the regression testing. This should help capture more of the code performance.
Related Work
@jtneedels noticed a possible issue of changes made in #1417. This will help avoid any potential unwanted changes.