-
Notifications
You must be signed in to change notification settings - Fork 913
CoolProp fluid model #1806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CoolProp fluid model #1806
Conversation
[WIP]feature_coolprop thermodynamics model
|
hi, is there anything I can do now |
|
Wait for the regression tests to pass, and if they pass you can merge this PR |
Thank you. But I think I do not have the right to merge this PR. |
|
Ok try again please after you accept the invite to the developers team. |
|
Thank you, I merged this PR. I will open a new PR recently, to introduce viscosity and conductivity from CoolProp. |
Proposed Changes
This project aims to couple the free and open-source thermodynamics library CoolProp with SU2.
There are two advantages:
CoolProp can provide accurate thermodynamics properties (P, T, rho, ect) of commone fluids by either extracting experiment data from published papers, or computing based on the state-of-the-art Helmholtz energy formulations.
So, thermodynamics properties obtained from CoolProp should be more accurate than those obtained from Van der Waals or peng robinson gas model embedded in SU2. Also, the numerical results should be more accurate.
To use CoolProp feature, the ony input from the user is the name of fluid. Then all other thermodynamics can be provided by CoolProp.
%FLUID_MODEL = COOLPROP
%FLUID_NAME = nitrogen
Related Work
This project references the following work:
1.the work of coupling 'Mutationpp' with SU2.
4. the pull request of 'Feature nppr gas #1718'
PR Checklist