Skip to content

Conversation

@PENGYAN777
Copy link
Contributor

@PENGYAN777 PENGYAN777 commented Nov 7, 2022

Proposed Changes

This project aims to couple the free and open-source thermodynamics library CoolProp with SU2.

There are two advantages:

  1. More accurate numerical results.
    CoolProp can provide accurate thermodynamics properties (P, T, rho, ect) of commone fluids by either extracting experiment data from published papers, or computing based on the state-of-the-art Helmholtz energy formulations.
    So, thermodynamics properties obtained from CoolProp should be more accurate than those obtained from Van der Waals or peng robinson gas model embedded in SU2. Also, the numerical results should be more accurate.
  2. More user-friendly
    To use CoolProp feature, the ony input from the user is the name of fluid. Then all other thermodynamics can be provided by CoolProp.
    %FLUID_MODEL = COOLPROP
    %FLUID_NAME = nitrogen

Related Work

This project references the following work:
1.the work of coupling 'Mutationpp' with SU2.
4. the pull request of 'Feature nppr gas #1718'

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings.
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • Simulations with the following test fluids succeed: nitrogen, oxygen, carbon dioxide, MM.
  • Currently, this new feature is applied for only Euler flow. For viscous flow, further work need to be done, including viscosity, conductivity from CoolProp.
  • CoolProp does not support non-dimension.

@PENGYAN777 PENGYAN777 mentioned this pull request Nov 7, 2022
6 tasks
@pcarruscag pcarruscag changed the title Feature coolprop CoolProp fluid model Nov 7, 2022
@PENGYAN777
Copy link
Contributor Author

hi, is there anything I can do now

@pcarruscag
Copy link
Member

Wait for the regression tests to pass, and if they pass you can merge this PR

@PENGYAN777
Copy link
Contributor Author

Wait for the regression tests to pass, and if they pass you can merge this PR

Thank you.

But I think I do not have the right to merge this PR.

@pcarruscag
Copy link
Member

Ok try again please after you accept the invite to the developers team.
I added you to the organization but maybe did not put you in a team.
This may also solve the other github issues.

@PENGYAN777 PENGYAN777 merged commit 9f76df4 into develop Nov 12, 2022
@PENGYAN777 PENGYAN777 deleted the feature_coolprop branch November 12, 2022 07:27
@PENGYAN777
Copy link
Contributor Author

Thank you, I merged this PR.

I will open a new PR recently, to introduce viscosity and conductivity from CoolProp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants