-
Notifications
You must be signed in to change notification settings - Fork 913
Generalized, quasi 3D look-up table #1825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… class with x and y
…as they're redundant. Added a 3D table unit test case
…_general_lookup_table
…_general_lookup_table
…_general_lookup_table
…_general_lookup_table
…el would not be selected properly
…_general_lookup_table
…code/SU2 into feature_general_lookup_table
…code/SU2 into feature_general_lookup_table
pcarruscag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything else on your side @bigfooted ?
@pcarruscag |
pcarruscag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok you can figure out the order you want to merge things.
LGTM
bigfooted
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed Changes
Generalize the variables in the CLookUpTable class for use in general look-up cases (not only progress variable-enthalpy).
Add dimension to CLookUpTable class to allow for quasi-3D interpolation (linear interpolation between two trapezoidal maps stacked in the third dimension).
I added a unit test as a test case with the quasi-3D table to show the correct use of syntax for 3D look-up operations.
Related Work
Can be used in feature_multilayer_perceptron in the CDataDrivenFluid fluid model for look-up operations.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.