Skip to content

Conversation

@WallyMaier
Copy link
Contributor

@WallyMaier WallyMaier commented Jan 13, 2023

Proposed Changes

This PR adds the capability to simulate the AIR-7 gas model using SU2TCLib for viscous problems. Specific contributions include:

  • Fix Gupta-Yos transport models for all flows (including ionized)
  • inclusion of Coulomb interaction cross sections for ion-ion collisions

Following the implementation detailed in Scalabrin's thesis.

Related Work

PRs #1497 #1555

Update to NEMO documentation includes description of GY model, see: su2code/su2code.github.io#116

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@WallyMaier WallyMaier changed the title [WIP] Adding ionization capabilities form viscous simulations (NEMO [WIP] Adding ionization capabilities form viscous simulations (NEMO) Jan 13, 2023
@jtneedels jtneedels changed the title [WIP] Adding ionization capabilities form viscous simulations (NEMO) [WIP] Adding ionization capabilities for viscous simulations (NEMO) Jan 13, 2023
@jtneedels
Copy link
Contributor

jtneedels commented Jan 13, 2023

Reading Scalabrin, he says the WBE transport model breaks down at Ttr > 10,000 K, and he uses the GY model for incorporating ionization in LeMANS. So I think the roadmap to for viscous/ionized flows is:

  1. Implement GY model according to Scalabrin wth Coulomb potential for ion-ion collisions
  2. Add some flag to make sure transport model for viscous-ionized is always GY

@WallyMaier
Copy link
Contributor Author

The path forward sounds good. Gupta-Yos needs to be reworked/fixed :(

@jtneedels
Copy link
Contributor

The path forward sounds good. Gupta-Yos needs to be reworked/fixed :(

Yeah, I'm working on that now. I think one way to do this would be to code in whether to use the Coulomb potential using the omega00 tables for each collision pair. For example, if omega00(ispecies, jspecies, 0) == 1.0, then use Coulomb. We could use 1.0, or some other non-physical value.

Signed-off-by: jtneedels <jneedels@stanford.edu>
Signed-off-by: jtneedels <jneedels@stanford.edu>
Signed-off-by: jtneedels <jneedels@stanford.edu>
Signed-off-by: jtneedels <jneedels@stanford.edu>
Signed-off-by: jtneedels <jneedels@stanford.edu>
Signed-off-by: jtneedels <jneedels@stanford.edu>
@jtneedels
Copy link
Contributor

An update: I re-worked this so the computation of the delta_ij values (used in each of the GY functions) is itself a function to remove repeated code. It is now also set up to handle ionized flows. Use of the Coulombic potential will signaled by the omega00 and omega11 values. Forward work is ensuring the correct collision integral curve fit values are used, modifying the omega00 and omega11 tables.

Signed-off-by: jtneedels <jneedels@stanford.edu>
Signed-off-by: jtneedels <jneedels@stanford.edu>
Signed-off-by: jtneedels <jneedels@stanford.edu>
Signed-off-by: jtneedels <jneedels@stanford.edu>
Signed-off-by: jtneedels <jneedels@stanford.edu>
@jtneedels
Copy link
Contributor

Okay, all tests should be passing (except some random new codefactor issues). Main issue with the GY models hanging is disambiguating which matrix of collision integral (omega) values to use, Scalabrin's notation is a bit unclear.

Are there other places we need to modify for including electrons? Anything in viscous numerics?

@WallyMaier WallyMaier merged commit 728cb8d into develop Feb 21, 2023
@WallyMaier WallyMaier deleted the feature_NEMO_visc_ion branch February 21, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants