-
Notifications
You must be signed in to change notification settings - Fork 913
Adding thermal conductivities to NEMO output #1889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
remove extra spaces
jtneedels
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I guess I'm curious if this is something we want to push into the base code though. To address LDK29, they would want this for the surface output.
|
So this will output the surface as well. Im thinking as more surface effects are looked at, it will become important. Especially when comparing different transport models. I know I used it extensively for in the RANS models. |
Good point, I was mis-remembering there to be separate AddSurfaceOutput.... Ok sounds good to me then! |
Proposed Changes
This PR adds the non-constant thermal conductivities to the NEMO output.
Related Work
Discussion #1888
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.