Skip to content

Conversation

@WallyMaier
Copy link
Contributor

Proposed Changes

This PR adds the non-constant thermal conductivities to the NEMO output.

Related Work

Discussion #1888

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Copy link
Contributor

@jtneedels jtneedels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I guess I'm curious if this is something we want to push into the base code though. To address LDK29, they would want this for the surface output.

@WallyMaier
Copy link
Contributor Author

So this will output the surface as well.

Im thinking as more surface effects are looked at, it will become important. Especially when comparing different transport models. I know I used it extensively for in the RANS models.

@jtneedels
Copy link
Contributor

So this will output the surface as well.

Im thinking as more surface effects are looked at, it will become important. Especially when comparing different transport models. I know I used it extensively for in the RANS models.

Good point, I was mis-remembering there to be separate AddSurfaceOutput....

Ok sounds good to me then!

@WallyMaier WallyMaier merged commit d240900 into develop Jan 16, 2023
@WallyMaier WallyMaier deleted the feature_nemo_ks branch January 16, 2023 13:27
@pr-triage pr-triage bot added the PR: merged label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants