Skip to content

Heat solver using scalar transport framework - Part 2 #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pcarruscag merged 20 commits into from
Jan 30, 2023
Merged

Heat solver using scalar transport framework - Part 2 #1892

pcarruscag merged 20 commits into from
Jan 30, 2023

Conversation

@pcarruscag
Copy link
Member

@pcarruscag pcarruscag commented Jan 16, 2023 •
edited
Loading

As discussed in the last dev meeting, this deprecates the centered scheme for weakly coupled heat transfer, because it had a bug in the speed of sound, and because this made it much easier to adapt the rest of the heat solver to the scalar framework.

Bonus:

  • Add SLOPE_LIMITER_HEAT option.
  • OpenMP of the heat solver.
  • Correct issues with Inlet and Outlet boundaries and gain farfield (not implemented before) for free.
  • Regression for weakly coupled heat equation (primal was not covered before).
  • PyCustom markers for heat solver.

ToDo:

  • Bounded scalar mode.
  • Docs.
  • Fix sensitivity wrt inlet velocity.

@pcarruscag pcarruscag mentioned this pull request Jan 16, 2023
Closed
WallyMaier
WallyMaier approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@WallyMaier WallyMaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@pcarruscag pcarruscag merged commit 5c976cb into develop Jan 30, 2023
@pcarruscag pcarruscag deleted the remove_centered_scalar branch January 30, 2023 04:48
@pr-triage pr-triage bot added the PR: merged label Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WallyMaier WallyMaier WallyMaier approved these changes

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pcarruscag @WallyMaier