Skip to content

Conversation

@Cristopher-Morales
Copy link
Contributor

Proposed Changes

This pull request adds the thermal conductivity, heat capacity and diffusivity as output for the incompressible solver in order to help the process of debugging inside SU2. During this process, we found some bugs regarding the diffusivity and thermal conductivity when the FLUID_MIXTURE model is used. Additionally, unused variables for computing the diffusivity have been removed.

Related Work

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Cristopher-Morales added 30 commits December 14, 2022 18:15
@Cristopher-Morales Cristopher-Morales changed the title [WIP] Addint thermal conductivity, heat capacity and diffusivity as outputs. [WIP] Adding thermal conductivity, heat capacity and diffusivity as outputs. Mar 6, 2023
@bigfooted
Copy link
Contributor

@Cristopher-Morales What's going on with the multizone test setup?

@Cristopher-Morales
Copy link
Contributor Author

@Cristopher-Morales What's going on with the multizone test setup?

I have updated the multizone restart file, I will update the residuals of this test case.

Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pcarruscag pcarruscag changed the title [WIP] Adding thermal conductivity, heat capacity and diffusivity as outputs. Adding thermal conductivity, heat capacity and diffusivity as outputs. Mar 9, 2023
@Cristopher-Morales Cristopher-Morales merged commit d886e44 into develop Mar 9, 2023
@Cristopher-Morales Cristopher-Morales deleted the feature_output_primitives branch March 9, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants