Skip to content

Conversation

@kursatyurt
Copy link
Contributor

Proposed Changes

The driver method Postprocessing() actually frees all the containers and finalizes the driver. As it does not reflect what is actually done and is easy to confuse with the method Postprocess(), the PR proposes renaming the method to Finalize().

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pcarruscag pcarruscag changed the title Rename Driver method Postprocessing to Finalize Rename python Driver method 'Postprocessing' to 'Finalize' Mar 21, 2023
@pcarruscag pcarruscag merged commit 15fabde into su2code:develop Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants