Skip to content

Conversation

@kursatyurt
Copy link
Contributor

Proposed Changes

Some tests in the parallel_regression.py was running in serial with the SU2_CFD command this PR changes them to default (mpirun -np 2 SU2_CFD).

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@kursatyurt
Copy link
Contributor Author

For the sliding interface case slinc_steady, I suppose the difference is caused by interpolation, but have no idea why cht_compressible fails.

Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please go ahead and update the regression values for those tests.

@kursatyurt kursatyurt merged commit 790de98 into su2code:develop Mar 21, 2023
@kursatyurt kursatyurt deleted the fix_parallel_regression branch March 21, 2023 21:14
@pr-triage pr-triage bot added the PR: merged label Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants