Skip to content

Conversation

@pcarruscag
Copy link
Member

Proposed Changes

I never found this scheme to be useful (not an improvement in either accuracy or robustness) and it is not used in any tests.

MUSCL_FLOW= YES is currently ignored for centered schemes, if we ever want to change that it would lead to backward compatibility issues, since we now have a chance to break it, I'm disallowing setting MUSCL_FLOW= YES with centered schemes.

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Copy link
Contributor

@WallyMaier WallyMaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have had terrible success with CUSP as well.

@pcarruscag pcarruscag merged commit 3f68501 into develop Mar 29, 2023
@pcarruscag pcarruscag deleted the remove_cusp branch March 29, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants