Skip to content

Unify Flow and FEA unsteady options + fix unsteady FEA adjoints + add FEA python wrapper examples #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pcarruscag merged 23 commits into from
Apr 23, 2023
Merged

Unify Flow and FEA unsteady options + fix unsteady FEA adjoints + add FEA python wrapper examples #2008

pcarruscag merged 23 commits into from
Apr 23, 2023

Conversation

@pcarruscag
Copy link
Member

@pcarruscag pcarruscag commented Apr 8, 2023

Proposed Changes

Use TIME_STEP and MAX_TIME in the FEA solver instead of DYN_*

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 8, 2023
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 8, 2023
View reviewed changes
pcarruscag
pcarruscag commented Apr 8, 2023
View reviewed changes
@kursatyurt
Copy link
Contributor

kursatyurt commented Apr 13, 2023

Nice clean-up/unification

@pcarruscag pcarruscag changed the title Unify Flow and FEA unsteady options + add FEA python wrapper example Unify Flow and FEA unsteady options + fix unsteady FEA adjoints + add FEA python wrapper example Apr 16, 2023
pcarruscag
pcarruscag commented Apr 16, 2023
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 17, 2023
View reviewed changes
@pcarruscag pcarruscag changed the title Unify Flow and FEA unsteady options + fix unsteady FEA adjoints + add FEA python wrapper example Unify Flow and FEA unsteady options + fix unsteady FEA adjoints + add FEA python wrapper examples Apr 17, 2023
@pcarruscag pcarruscag merged commit 2bb4550 into develop Apr 23, 2023
@pcarruscag pcarruscag deleted the fea_time_params branch April 23, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

changelog:fix PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pcarruscag @kursatyurt