Skip to content

Fix meson issues #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pcarruscag merged 2 commits into from
Jul 28, 2023
Merged

Fix meson issues #2093

pcarruscag merged 2 commits into from
Jul 28, 2023

Conversation

@jblueh
Copy link
Contributor

@jblueh jblueh commented Jul 27, 2023 •
edited
Loading

Proposed Changes

This PR fixes small issues in the meson build system that I noticed during recent work on SU2.

  1. deprecation warnings about meson.source_root()
  2. an incorrectly displayed ninja command

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

pcarruscag
pcarruscag approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing these

@jblueh
Copy link
Contributor Author

jblueh commented Jul 28, 2023

Thank you for fixing these

Thanks for the approval @pcarruscag. I can't merge though, the formatting workflow seems to be stuck?

@pcarruscag
Copy link
Member

pcarruscag commented Jul 28, 2023

Interesting

@pcarruscag pcarruscag merged commit 8105a75 into develop Jul 28, 2023
@pcarruscag pcarruscag deleted the fix_meson_issues branch July 28, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcarruscag pcarruscag pcarruscag approved these changes

Assignees

No one assigned

Labels

changelog:fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jblueh @pcarruscag