Python interface for updating translation and rotation rates of markers #2095

HahsFilip · 2023-07-28T12:14:09Z

Proposed Changes

Give a brief overview of your contribution here in a few sentences.
My changes allow the changing of moving wall velocities when using the py_wrapper.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
There has been some previous work, where functionality for changing mesh rotation rates was added.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

[X ] I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

HahsFilip · 2023-07-28T12:15:36Z

@pcarruscag This is my first PR, so I hope that at least a few things will be ok :)

TestCases/py_wrapper/rotating_cylinder/run.py

…/SU2 into py_wrapper_moving_wall

Common/include/CConfig.hpp

SU2_CFD/include/drivers/CDriver.hpp

SU2_CFD/src/iteration/CIteration.cpp

SU2_CFD/src/python_wrapper_structure.cpp

Common/include/CConfig.hpp

SU2_CFD/src/python_wrapper_structure.cpp

pcarruscag · 2023-07-30T00:15:28Z

TestCases/py_wrapper/rotating_cylinder/run.py

@@ -0,0 +1,26 @@
+import pysu2			            # imports the SU2 wrapped module


Thanks 👍 to make a regression test from this you need to add it to parallel_regression.py

Add our license header to this file please (since it's also code).

TestCases/py_wrapper/rotating_cylinder/run.py

HahsFilip · 2023-07-30T19:06:30Z

I'm having some trouble getting the regression tests to pass - for some reason there is a result difference in the moving wall tests. I'm not sure how this can be possible, considering I am not changing any values. The convergence seems to be slowed down considerably, but I'm having trouble identifying which function may be causing this.

pcarruscag · 2023-07-30T22:49:51Z

Why do you say the convergence is slowed down? It looks like a very small change. Did you run the cases for more iterations?

HahsFilip · 2023-07-31T06:15:14Z

Well, I've noticed the problem, because the unit tests don't pass - cavity and spinning cylinder especially. They exceed the number of iterations, and at the same time there is a result discrepancy. Increasing the number o iterations in serial_regression.py does not help, in fact it makes the delta worse.

HahsFilip · 2023-07-31T11:19:27Z

I'm actually having the same problems running the code on the develop branch....

pcarruscag · 2023-07-31T15:24:30Z

Thank can be just due to compilation differences.
Take those two cases and run them until convergence, e.g. 6 orders drop in residuals, then compare the results and if they converge in a similar number of iterations.
If all looks the same we can update the reference values in the test.

HahsFilip · 2023-07-31T19:31:59Z

So you mean I should run the tests to convergence, and compare the results between branches? I wonder why compilation problems could be the culprit, as the tests fail both locally and in the github test. Shouldn't the github test always be compiled the same way?

pcarruscag · 2023-07-31T19:36:00Z

You mentioned issues with the develop branch, those are likely due to compilation differences.
Yes run to convergence with both branches and compare please. I expect integrated quantities will be exactly the same.

pcarruscag

Hey @HahsFilip do you think you can wrap this up?
Take care of Kursat's comments and update the failing tests since it seem to be just numerical noise (or do you have reason to believe otherwise?)

SU2_CFD/include/drivers/CDriver.hpp

SU2_CFD/src/python_wrapper_structure.cpp

Co-authored-by: Kürşat Yurt <57598663+kursatyurt@users.noreply.github.com>

pcarruscag · 2023-10-26T12:39:19Z

You also need to add yourself to the AUTHORS.md file

… to authors

HahsFilip · 2023-11-04T08:51:21Z

@pcarruscag, sorry for the delay I had to get my life together a bit after the conference :). I think I have the correct changes, I have changed the tests and removed unused lines.

Filip

…wrapper_moving_wall

pcarruscag

LGTM

pcarruscag · 2023-11-05T11:13:54Z

TestCases/py_wrapper/rotating_cylinder/run.py

@@ -0,0 +1,26 @@
+import pysu2			            # imports the SU2 wrapped module


Add our license header to this file please (since it's also code).

…/SU2 into py_wrapper_moving_wall

pcarruscag · 2023-11-10T15:44:59Z

externals/codi

You need to revert these changes to submodules, this may be why you see some failing cases

This reverts commit 4e36eee.

kursatyurt · 2023-11-17T01:20:51Z

@pcarruscag , @HahsFilip

Do the hybrid tests need an update? Do any of you have any idea about why they are failing?

pcarruscag

Because this branch has the wrong versions of various submodules

kursatyurt · 2023-11-17T08:39:31Z

Because this branch has the wrong versions of various submodules

I see I assumed the last commit reverted all. As it is on a fork we cannot revert 👍🏼

kursatyurt · 2023-12-06T21:48:15Z

@pcarruscag, is it possible to merge this PR to some temporary branch in the SU2 repo, fix the broken submodules there, and merge it to the main branch? It looks like @HahsFilip is busy. PR is almost complete but cannot be merged. I will do the required fixes.

pcarruscag · 2023-12-06T23:03:45Z

Thanks @kursatyurt submodules are fixed here 8b89e85
If you can do the other fixes and hook up the regression test it would be great

kursatyurt · 2023-12-07T02:32:57Z

Thanks @pcarruscag , it looks like standard regression tests are passed without any problem, and ARM tests are problematic, as always.

HahsFilip and others added 4 commits July 11, 2023 13:24

add basic support for rotation changes

3e8ba47

add translation

5fdc664

add example

ba0e732

Merge branch 'develop' into py_wrapper_moving_wall

e5fde5c

kursatyurt changed the title ~~Ability to change moving walls using the py_wrapper~~ Python interface for updating translation and rotation rates of markers Jul 28, 2023

kursatyurt added the changelog:feature label Jul 28, 2023

Merge branch 'develop' into py_wrapper_moving_wall

0368765

github-advanced-security bot found potential problems Jul 28, 2023

View reviewed changes

HahsFilip added 3 commits July 29, 2023 08:50

remove unused imports

ce66598

Merge branch 'py_wrapper_moving_wall' of https://github.com/HahsFilip…

f8a76fe

…/SU2 into py_wrapper_moving_wall

i hope the test will pass

5d90c34

pcarruscag reviewed Jul 30, 2023

View reviewed changes

Apply suggestions from code review

7331adb

pcarruscag reviewed Jul 30, 2023

View reviewed changes

Common/include/CConfig.hpp Outdated Show resolved Hide resolved

SU2_CFD/src/python_wrapper_structure.cpp Outdated Show resolved Hide resolved

Apply suggestions from code review

eb21853

pcarruscag reviewed Jul 30, 2023

View reviewed changes

kursatyurt reviewed Jul 30, 2023

View reviewed changes

TestCases/py_wrapper/rotating_cylinder/run.py Outdated Show resolved Hide resolved

TestCases/py_wrapper/rotating_cylinder/run.py Outdated Show resolved Hide resolved

kursatyurt reviewed Jul 30, 2023

View reviewed changes

TestCases/py_wrapper/rotating_cylinder/run.py Outdated Show resolved Hide resolved

kursatyurt reviewed Jul 30, 2023

View reviewed changes

TestCases/py_wrapper/rotating_cylinder/run.py Outdated Show resolved Hide resolved

Merge branch 'develop' into py_wrapper_moving_wall

269fbc0

Merge branch 'develop' into py_wrapper_moving_wall

c4a781d

Merge branch 'develop' into py_wrapper_moving_wall

99fece9

pcarruscag reviewed Oct 26, 2023

View reviewed changes

SU2_CFD/include/drivers/CDriver.hpp Show resolved Hide resolved

SU2_CFD/src/python_wrapper_structure.cpp Outdated Show resolved Hide resolved

pcarruscag and others added 2 commits October 26, 2023 13:38

Apply suggestions from code review

32dcd85

Co-authored-by: Kürşat Yurt <57598663+kursatyurt@users.noreply.github.com>

Merge branch 'develop' into py_wrapper_moving_wall

0396de8

HahsFilip and others added 2 commits November 4, 2023 09:49

chaged tests to remove numerical noise, remove unused lines, add name…

a7f4e92

… to authors

Merge branch 'develop' into py_wrapper_moving_wall

fc652dd

HahsFilip added 2 commits November 4, 2023 11:46

change fsi serial regression test

d0486c1

Merge remote-tracking branch 'origin/py_wrapper_moving_wall' into py_…

dfd8dab

…wrapper_moving_wall

pcarruscag approved these changes Nov 5, 2023

View reviewed changes

HahsFilip and others added 3 commits November 9, 2023 15:53

Merge branch 'develop' into py_wrapper_moving_wall

00f9f14

more test changes

4e36eee

Merge branch 'py_wrapper_moving_wall' of https://github.com/HahsFilip…

ca5f06c

…/SU2 into py_wrapper_moving_wall

pcarruscag reviewed Nov 10, 2023

View reviewed changes

externals/codi

Copy link

Member

pcarruscag Nov 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to revert these changes to submodules, this may be why you see some failing cases

HahsFilip and others added 2 commits November 12, 2023 16:15

Revert "more test changes"

a009c2e

This reverts commit 4e36eee.

Merge branch 'develop' into py_wrapper_moving_wall

0adab08

Merge branch 'develop' into py_wrapper_moving_wall

d63931b

pcarruscag reviewed Nov 17, 2023

View reviewed changes

Merge branch 'develop' into py_wrapper_moving_wall

980551c

pcarruscag merged commit 99141db into su2code:develop Dec 6, 2023

		@@ -0,0 +1,26 @@
		import pysu2 # imports the SU2 wrapped module

Python interface for updating translation and rotation rates of markers #2095

Python interface for updating translation and rotation rates of markers #2095

Uh oh!

Conversation

HahsFilip commented Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Related Work

PR Checklist

Uh oh!

HahsFilip commented Jul 28, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pcarruscag Jul 30, 2023

Choose a reason for hiding this comment

Uh oh!

pcarruscag Nov 5, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HahsFilip commented Jul 30, 2023

Uh oh!

pcarruscag commented Jul 30, 2023

Uh oh!

HahsFilip commented Jul 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HahsFilip commented Jul 31, 2023

Uh oh!

pcarruscag commented Jul 31, 2023

Uh oh!

HahsFilip commented Jul 31, 2023

Uh oh!

pcarruscag commented Jul 31, 2023

Uh oh!

pcarruscag left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pcarruscag commented Oct 26, 2023

Uh oh!

HahsFilip commented Nov 4, 2023

Uh oh!

pcarruscag left a comment

Choose a reason for hiding this comment

Uh oh!

pcarruscag Nov 5, 2023

Choose a reason for hiding this comment

Uh oh!

pcarruscag Nov 10, 2023

Choose a reason for hiding this comment

Uh oh!

kursatyurt commented Nov 17, 2023

Uh oh!

pcarruscag left a comment

Choose a reason for hiding this comment

Uh oh!

kursatyurt commented Nov 17, 2023

Uh oh!

kursatyurt commented Dec 6, 2023

Uh oh!

pcarruscag commented Dec 6, 2023

HahsFilip commented Jul 28, 2023 •

edited

Loading

HahsFilip commented Jul 31, 2023 •

edited

Loading