Skip to content

Conversation

@Irvise
Copy link
Contributor

@Irvise Irvise commented Sep 19, 2023

Proposed Changes

Update CoolProp to v6.5.0 which was recently released. I picked the commit of the release, but newer commits are available. I also "cleaned up" a bit the submodule function so that it would become easier to update CoolProp in the future and make the intent of the code clearer.

Related Work

CoolProp v6.5.0 has an updated EOS for CO2, with which I am currently playing around. This new version has the same EOS as NIST. It also comes with a variety of bug fixes and improvements.

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • The code generates quite a few warning when compiling on Debian 12, which uses GCC12 , but none were introduced in this commit. I tested the compilation using an Apptainer/Singularity container.
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I changed the Python code, for which I saw no entry in the style guide.
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I did not run it as I did not know about it, but I do not think it applies for this (though maybe it does)
  • I have added a test case that demonstrates my contribution, if necessary.
  • Not necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.
  • No documentation related to SU2 should be affected.

I do have one question which is not directly related to this PR. I have an Apptainer/Singularity container for SU2 which has most of the bells and whistles. I saw that you have docker containers, but for HPC (and normal computers) Docker can have a large performance penalty. Would you like for me to contribute my Apptainer recipes?

Any and all feedback welcome!

P.S: I did not know that even after updating the hash commit of CoolProp in the meson script, I also had to update the submodule, that is not very intuitive. In this current state, the Meson commit hash has little to no value if it gets changed independently afterwards :)
P.P.S: I also did not know that SU2 v8.0 was going to be released this earlier, otherwise I would have tried to get it updated earlier!

Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PENGYAN777 please review

@pcarruscag pcarruscag changed the title Update CoolProp Update CoolProp to v6.5.0 Sep 25, 2023
@pcarruscag pcarruscag merged commit f329d95 into su2code:develop Sep 25, 2023
@Irvise Irvise deleted the update_coolprop branch September 25, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants