Upgrade external CGNS library to 4.4 release. #2179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| set_error(NO_ERROR, err); | ||
| } | ||
| else if (option == ADFH_CONFIG_ELINK_FILE_CACHE_SIZE) { | ||
| h5pset_elink_file_cache_size_size = (unsigned)((size_t)value); |
Check warning
Code scanning / CodeQL
Local variable address stored in non-local memory
MicK7
force-pushed
the
update_cgns_to_4.4
branch
2 times, most recently
from
d7cf89a to
a11dd92
Compare
pcarruscag
approved these changes
Dec 1, 2023
MicK7
force-pushed
the
update_cgns_to_4.4
branch
from
52993cb to
6b1b59a
Compare
| CGNS_ENUMT(DataType_t) type; | ||
|
|
||
| /* get memory address of file */ | ||
| cg = cgi_get_file(file_number); |
Check failure
Code scanning / CodeQL
Inconsistent nullness check
| CGNS_ENUMT(DataType_t) type; | ||
|
|
||
| /* get memory address of file */ | ||
| cg = cgi_get_file(file_number); |
Check failure
Code scanning / CodeQL
Inconsistent nullness check
|
|
||
| zone = cgi_get_zone(cg, B, Z); | ||
| if (zone==0) return CG_ERROR; | ||
| cg = cgi_get_file(fn); |
Check failure
Code scanning / CodeQL
Inconsistent nullness check
MicK7
force-pushed
the
update_cgns_to_4.4
branch
from
6b1b59a to
4353e18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The files of the external CGNS library included with SU2 are upgraded to 4.4 release.
This will allow reading files generated with recent version of CGNS that are currently rejected because SU2 included version is a bit old.
Related Work
No issue created yet but some users did comment about it.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.