Skip to content

Conversation

@jblueh
Copy link
Contributor

@jblueh jblueh commented Aug 13, 2024

Proposed Changes

Test if the ASLR fix (#2241, #2242) is still needed.

ASAN and TSAN tests pass without the fix, the issue has probably been fixed in the GitHub runner.

Related Work

#2241, #2242

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@jblueh jblueh changed the title [WIP] Test if ASLR fix is still needed. ASLR fix no longer needed Aug 13, 2024
@jblueh
Copy link
Contributor Author

jblueh commented Aug 13, 2024

The formatting CI seems to hang. Can you merge it @pcarruscag?

@pcarruscag pcarruscag merged commit 6d26b90 into develop Aug 14, 2024
@pcarruscag pcarruscag deleted the fix/aslr branch August 14, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants