Skip to content

Conversation

@EvertBunschoten
Copy link
Member

@EvertBunschoten EvertBunschoten commented Oct 18, 2024

Proposed Changes

Updated the MLPCpp submodule which is now able to use different scaling methods (standard, robust, and min-max) for scaling the neural network inputs and outputs.

Related Work

This update relates to the parts of SU2 regarding data-driven simulations (CDataDrivenFluid and CFlameletFluid).

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@EvertBunschoten EvertBunschoten self-assigned this Oct 18, 2024
@EvertBunschoten EvertBunschoten added dependencies Pull requests that update a dependency file changelog:feature labels Oct 18, 2024
@joshkellyjak
Copy link
Contributor

Maybe a good oppurtunity to correct this issue?

#2366

@EvertBunschoten EvertBunschoten changed the title [WIP]Updated MLPCpp module supporting additional input/output scaling methods Updated MLPCpp module supporting additional input/output scaling methods Oct 31, 2024
@EvertBunschoten
Copy link
Member Author

Maybe a good oppurtunity to correct this issue?

#2366

I swapped the descriptions so once this PR is closed we can close the issue as well.

Copy link
Contributor

@bigfooted bigfooted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvertBunschoten EvertBunschoten merged commit c2da451 into develop Nov 4, 2024
@EvertBunschoten EvertBunschoten deleted the update_MLPCpp branch November 4, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:feature dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants