Skip to content

Conversation

@Vaish-W
Copy link
Contributor

@Vaish-W Vaish-W commented Dec 22, 2024

Proposed Changes

This pull request adds the capability to compute thermal stresses in Neo-Hookean materials in SU2. It includes:

  • Updates to the CFEM_NeoHookean_Comp class to incorporate thermal stress contributions under CFEM_NeoHookean_Comp::Compute_Stress_Tensor.
  • Extensions to the CElement class for handling temperature at the element and nodal levels.
  • Used integration of configuration parameters (Thermal Expansion Coefficient, Reference Temperature) to update stress tensor
  • Pending: Add test case for Single-Element Thermoelastic Test to test implementation.

Related Work

This feature addresses thermal stress computation for the nonlinear elasticity module. It sets the groundwork for future problems, such as thermoelasticity in bimetallic strips. No specific issues or PRs are related.

PR Checklist

  • [ X ] I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • [ X ] My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@bigfooted bigfooted changed the base branch from master to develop December 22, 2024 12:41
@Vaish-W Vaish-W changed the title Feature: Thermal stress computation for Neo-Hookean material model Thermal stress computation for Neo-Hookean material model Dec 22, 2024
@bigfooted bigfooted changed the title Thermal stress computation for Neo-Hookean material model [WIP] Thermal stress computation for Neo-Hookean material model Dec 22, 2024
@pcarruscag
Copy link
Member

Thank you for the contribution, I was curious after you talked about this on slack and I have an implementation that is a little more polished.
I will open a PR shortly and then maybe you can work on coupling with the heat solver?
I didn't realize you were going to work on this, most people that ask whether the code can do something are not interested in doing it 😅 , but I'm glad you want to get your hands in the code! 😄

@Vaish-W
Copy link
Contributor Author

Vaish-W commented Dec 23, 2024

Hi @pcarruscag, I understand this might not be a good implementation as you expect. But could you please tell me the changes if possible? So that I could work on this further. Are there a lot of changes or is my formulation itself wrong? I want to learn doing it completely. 😄

Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I left some comments and you can see more here: #2399

Let me know if you want to work on coupling the heat solver with the structural solver (read the nodal temperatures from the heat solver).
I can add you to the SU2 org.

Comment on lines +310 to +316
inline su2double ComputeAverageTemperature(void) const {
su2double sum_temperature = 0.0;
for (const auto &temp : nodal_temperatures) {
sum_temperature += temp;
}
return nodal_temperatures.empty() ? 0.0 : (sum_temperature / nodal_temperatures.size());
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it should be the temperature interpolated at the Gaussian integration points.

Comment on lines +112 to +114
/*--- Thermal stress parameters ---*/
su2double alpha = config->GetThermal_Expansion_Coeff(); // Coefficient of thermal expansion
su2double delta_T = element->GetTemperature() - config->GetTemperature_Ref(); // Temperature difference
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FEA solver has a way to use different materials in different parts of the structure, so I introduced one alpha per material.
The reference temperature you use here is used by some solver for non dimensionalization, so it was better to use a dedicated temperature.
I also added this stress contribution to all material models.

@Vaish-W
Copy link
Contributor Author

Vaish-W commented Dec 24, 2024

Sure, I left some comments and you can see more here: #2399

Let me know if you want to work on coupling the heat solver with the structural solver (read the nodal temperatures from the heat solver). I can add you to the SU2 org.

Thank you for your comments and I got the changes from PR#2399. Also, I would like to work on coupling of heat and structural solver.

@pcarruscag
Copy link
Member

Great, then I'll merge my PR, close this one, add you to the SU2 org (then you can create branches in the su2code repo directly and it's easier to collaborate), and I'll start a discussion with some notes on how you can start coupling the solvers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants