Skip to content

Conversation

@bigfooted
Copy link
Contributor

Proposed Changes

For some reason, the Sudo regression tests were different in the von karman tutorial.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@bigfooted bigfooted changed the title change regression Change regression values for 90 degree bend Mar 9, 2025
@pcarruscag
Copy link
Member

Is that test used in the asan tests?

@bigfooted
Copy link
Contributor Author

Is that test used in the asan tests?

No, just the tutorial regression changed. It was different in the von karman PR. I might have missed an update due to the change in the 90 degree bend tutorial.

@bigfooted
Copy link
Contributor Author

ok, this seems to be the correct regression values, so I am merging it in...

@bigfooted bigfooted merged commit f6db7d4 into develop Mar 9, 2025
37 of 38 checks passed
@bigfooted bigfooted deleted the fix_sudo_regression branch March 9, 2025 11:49
raghava-davuluri pushed a commit to hypersonic-lab/SU2 that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants