Skip to content

Conversation

@vdweide
Copy link
Contributor

@vdweide vdweide commented May 14, 2025

Proposed Changes

Small PR, which changes the names of the variables of the template inlet profile file to the correct names.
The names that were written to the template profile file for inlets were not consistent with the actual variables for some boundary conditions. E.g. for a supersonic inlet the velocity components are written, but the names used were NORMAL_X, NORMAL_Y and NORMAL_Z, which is confusing. Something similar for the total inlet conditions for a subsonic inlet for which the total temperature and total pressure are written, but the names were TEMPERATURE and PRESSURE. This has been corrected.

Related Work

None

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@vdweide
Copy link
Contributor Author

vdweide commented May 14, 2025

Don't look at it yet. I accidentally did a reformatting in VSCode of the file. Let me undo that first.

@vdweide
Copy link
Contributor Author

vdweide commented May 14, 2025

Don't look at it yet. I accidentally did a reformatting in VSCode of the file. Let me undo that first.

Should be good now.

@vdweide vdweide merged commit b49318e into develop May 16, 2025
35 checks passed
@vdweide vdweide deleted the names_inlet_profile branch May 16, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants