Skip to content

Conversation

@bigfooted
Copy link
Contributor

@bigfooted bigfooted commented Aug 29, 2025

Proposed Changes

Use inlet normal for flow direction when INLET_USE_NORMAL=YES
This is an extension of INC_INLET_USENORMAL to compressible flow.
INC_INLET_USENORMAL will then be removed.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the same for NEMO while you're at it?

bigfooted and others added 4 commits August 29, 2025 22:25
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
@pcarruscag pcarruscag changed the title Option to use inlet normal for compressible inlets Option to use inlet normal to boundary also for compressible inlets Aug 30, 2025
@pcarruscag pcarruscag merged commit 8b79b7d into develop Aug 30, 2025
37 checks passed
@pcarruscag pcarruscag deleted the feature_comp_inlet_usenormal branch August 30, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants