-
Notifications
You must be signed in to change notification settings - Fork 913
Document tutorial result discrepancies for issue #1604 #2680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Document tutorial result discrepancies for issue #1604 #2680
Conversation
pcarruscag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned, what is needed is a fix for the discrepancy, not a note on its existence.
|
Thanks for the feedback @pcarruscag! I understand now - you want the actual fix, not just documentation.I have two questions before proceeding:
Which approach would you prefer for each case? |
You should update the config file, then rerun the testcase to verify that it works correctly, then update the webpages, files and figures and regression test results. |
|
@pcarruscag I've done a comprehensive search and found a critical issue: The "Unsteady Pitching NACA0012" test case from the website tutorial does not exist in the repository. My search: # Search for unsteady NACA0012 configs
find . -type f -name "*.cfg" | xargs grep -l "NACA.*0012" | grep -i unsteady
# Found only:
- plunging_naca0012 (PLUNGING, not pitching)
- disc_adj_euler/naca0012_pitching (ADJOINT, not forward)Available in TestCases/unsteady/:
The Problem:
Please advise on the correct approach. |
|
- Created TestCases/unsteady/pitching_naca0012/ directory - Added config with corrected parameters (CFL, LINEAR_SOLVER_*) - Documented fixes based on forum feedback - Resolves test case availability for tutorial Addresses su2code#1604
- Updated non-dimensionalization settings - Ensures tutorial reproducibility Addresses su2code#1604
7852568 to
c1540a3
Compare
- TIME_STEP = 0.005 - CFL_NUMBER = 1e12 - LINEAR_SOLVER_ERROR = 0.1 - LINEAR_SOLVER_ITER = 10 - Updated mesh filename and description
Proposed Changes
This PR documents tutorial result discrepancies reported by users in issue #1604. Based on forum thread analysis, two tutorials produce results that don't match the website documentation:
This documentation serves as a basis for updating the affected tutorials or their documentation pages.
Related Work
PR Checklist
pre-commit run --allto format old commits.