The `next_result`/`prev_result` hooks don't jump to the next/prev diagnostic if there are build results

[timfjord]

Describe the bug
The next_result/prev_result hooks don't jump to the next/prev diagnostic if there are build results

To Reproduce
Steps to reproduce the behaviour:

1. Initiate a build
2. Introduce an LSP error in some file
3. Press f4(the default next_result shortcut)
4. Observe nothing happens

Expected behaviour
The error should be highlighted

Environment (please complete the following information):

• OS: macOs 0.15.7
• Sublime Text version: 4107
• LSP version: 1.4.0
• Language servers used: ruby(solargraph, sorbet)

[wilkystyle]

It appears that this also happens when generating search results (the next_result/previous_result functionality applies to searches, not LSP diagnostics). The only way I know to get back to navigating LSP results is to quit and restart Sublime Text.

(I'm also on build 4107)

[timfjord]

I think closing the search result page(or the search panel) should fix the problem. But there is no such thing for builds, there is no way to reset the build without restarting Sublime

[wilkystyle]

I think closing the search result page(or the search panel) should fix the problem. But there is no such thing for builds, there is no way to reset the build without restarting Sublime

At least for me, closing the search page doesn't restore my ability to navigate between LSP diagnostics with next_result or previous_result—it simply disables navigating between search results, with next_result/previous_result no longer performing any action.

[htmue]

While working on #1868, I found out what's going on here:

When there is more than one result list open, only one of them has the focus of next_result/previous_result. When that focus is not on the LSP results anymore (after build command, global search, ...), you can get it back there by double clicking on a result in the diagnostics panel (which of course has to be open, and I normally have it hidden, so, well...), and vice versa.

This way you can switch back and forth between LSP diagnostics, build errors, search results...

Closing the search page doesn't do the trick, but this does.

[timfjord]

Cool, thanks for the tip @htmue
It might make sense to add a command(menu item) to quickly reopen and focus on the references panel

I am going to close this one, as it is how Sublime works and not really related to LSP itself

[rchl]

This should just be fixed by not relying on the ST's built-in build results handling.

[timfjord]

Hm, this change was introduced last year #1533
I guess this is another edge case and it looks like it hasn't been considered initially

[htmue]

Actually I was thinking about this quite a bit, because I was really annoyed myself. In the end I came to the conclusion that the way it works now is exactly how it should be.

LSP used to have its own handling once, I think it was on F8/shift+F8. This had its issues too, mainly because it was not using ST's built-in handling.

Now you just reach for F4/shift+F4, as always. This is what you expect as a Sublime user and it works almost like with build/find results, with that one big exception:

With build/find you actively initiate a new result list, which you rightfully can expect to be the active one afterwards. Language servers, on the other hand, send diagnostics all the time while you're editing or switching buffers. If receiving them would activate the diagnostics result list (which at first seems to be a good idea) it would be really bad when you for example are going through find results with many files, making an edit here and there. That would trigger new diagnostics, steal F4 from the find results and mess up your workflow.

The mouse is a bit too far away sometimes. Would be nice if opening the diagnostics panel would activate it for F4, there is already a command with a shortcut for that. Is there a way of telling ST to do this?

[rchl]

LSP used to have its own handling once, I think it was on F8/shift+F8. This had its issues too, mainly because it was not using ST's built-in handling.

What issues did it have?

Now you just reach for F4/shift+F4, as always.

I'd prefer to have separate keys for navigating diagnostics and not have to worry about that part stopping working randomly.

Also, the built-in behavior keeps its own index for navigating the "results" so it will always start from the beginning of the results which might not be the file I'm actually editing. So pressing "next result" will jump to some other file even if I wanted to go to the next diagnostic in the current file.

[htmue]

What issues did it have?

There was something that made me stumble, perhaps it was already solved. It was a lot of code, which is an issue in itself. And it wasn't on F4, which was an issue for me. But I get your point, YMMV.