[AC] AC not showing up with a "decorated" trigger

[predragnikolic]

Note: check if only DYNAMIC_COMPLETIONS are affected.

When I supplement the completion by typing more characters, the completion widget goes away.

---

I don't get a completion widget at all sometimes. In the gif below I expect to at least see a completion for the "time" variable:

I'm guessing this is due to incomplete completions. I'm not sure what the dynamic is here.

Originally posted by @rwols in #866 (comment)

[rwols]

As it turns out this is due to clangd putting a space in the label. We can remove the space with the command-line option --header-insertion-decorators.

With --header-insertion-decorators=0: (looks like there's a bug in the insertion logic)

Without --header-insertion-decorators=0:

Currently, we're mapping the label of an LSP completion item to the trigger of a sublime completion item. But as can be seen with clangd, this is wrong.

As I mentioned way back, the concept of trigger in SublimeText seems to map better to the filterText of an LSP completion item. However, that makes the completions look a bit bare.

This is with trigger=item["label"] and --header-insertion-decorators=0:

This is with trigger=item.get("filterText") or item["label"] and --header-insertion-decorators=0:

What we need is a distinction between label and trigger in SublimeText. cc @jskinner

[predragnikolic]

I wonder if "autocomplete_preserve_order": "none" would help in this case?

[rwols]

Indeed, setting auto_complete_preserve_order to "none" seems to fix the problem. Below is without --header-insertion-decorators=0.

Based on this I am inclined to say that we should put self.view.settings().set("auto_complete_preserve_order", "none") in completion.py.

Still, what the user sees in the AC widget, and what the user is expected to type to trigger the completion are two different concepts.

[rwols]

After googling about filterText I cannot find much information about it other than "it is filter text".
I thought that filterText would be a substring of label, but some language servers actually seem to be making the label a substring of the filterText. Some language servers decide that there's no substring relation between filterText and label at all. At this point I'm beginning to wonder what the point of filterText is or whether it is just a vscode implementation detail leaking into the protocol.

[rwols]

Fixed by #945

[jskinner]

A bit late here, but FWIW:

• "auto_complete_preserve_order": "some" (the default) is more aggressive about filtering out matches than "none", and part of this is that the first character of the trigger must match a character in buffer.

• Sublime Text doesn't have a notion of separate filter text vs label text. I'm not sure how that could even work: the user selects the text they want inserted by typing part of what they can see, and we bold the matched characters. If the filter text is "foo", and the label text is "bar", it would be nonsensical.