Fix CodeActionTriggerKind enum access #2484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sublime-lsp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
predragnikolic
approved these changes
May 29, 2024
Member
predragnikolic
left a comment
predragnikolic
left a comment
There was a problem hiding this comment.
A bug that was missed
I do not consider the current behavior a bug.
With the current main the server still receives the correct int.
I will merge this regardless,
because this PR makes the triggerKind easer to read in the LSP log panel.
Member
Author
|
You're right, technically the server communication wasn't affected by this, so maybe it's not a bug. I think I had earlier seen errors in the console about not being able to serialize the enums to JSON, but apparently it does still work and perhaps I remembered that wrong (or there was a different cause). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug that was missed, resulting from importing the
enumstdlib on Python 3.8 (compare #2446 (comment)).