Skip to content

Conversation

@jwortmann
Copy link
Member

As previously mentioned in #2568 (comment) I see no use case for this configuration file. If there is some entry missing in the current language ID mapping (like a new syntax with unconventional base scope), it would be better for everyone to fix it directly in the LSP package, rather than allowing users to add individual overrides. If anyone sees any use case that I missed, please correct me if I'm wrong.

@predragnikolic
Copy link
Member

I will see to merge this if no other reviews appear.

@jwortmann
Copy link
Member Author

Maybe wait a day or two to see if there is anything that would be against this change. Because it is a somewhat breaking change. I wonder if this configuration file was ever used by anybody.

@predragnikolic
Copy link
Member

predragnikolic commented Feb 17, 2025

@jwortmann 3eea50a will make this a not breaking change for now:

LSP will function as before,
but a deprecation warning will be shown to the user,
The warning in the sublime console will redirect them to the migration guide #2592
This will give time LSP users to migrate before we actually remove the file in the next minor release. (I took the liberty to choose the time, but I'm fine with if you want a differently date)


More importantly, I will revert the change if you do not find it appropriate.

@predragnikolic predragnikolic force-pushed the hardcode-language-id-map branch from f8c2ee9 to faac375 Compare February 17, 2025 10:59
@predragnikolic predragnikolic force-pushed the hardcode-language-id-map branch from faac375 to 3eea50a Compare February 17, 2025 11:02
@jwortmann
Copy link
Member Author

Okay the change looks fine, good idea.

@predragnikolic predragnikolic merged commit ecf23ee into sublimelsp:main Feb 18, 2025
8 checks passed
@predragnikolic predragnikolic changed the title Remove language IDs configuration file Deprecate language IDs configuration file Feb 18, 2025
@jwortmann jwortmann deleted the hardcode-language-id-map branch February 18, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants