Add on_selection_modified_async API method #2657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwortmann
commented
Oct 7, 2025
| if not self._is_in_higlighted_region(first_region.b): | ||
| self._clear_highlight_regions() | ||
| self._clear_code_actions_annotation() | ||
| if userprefs().document_highlight_style or userprefs().show_code_actions: |
Member
Author
There was a problem hiding this comment.
Note that I removed this if-condition here for simplicity (otherwise we would need to check beforehand whether there is at least one session with a plugin). Iirc I added this condition a while ago to reduce unnecessary debouncing calls if neither highlights nor code actions are enabled in the user settings. But I assume that typically at least one of those features is enabled, so probably this condition was relatively useless in almost all cases anyway.
rchl
approved these changes
Oct 7, 2025
Co-authored-by: Rafał Chłodnicki <rchl2k@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function to notifiy plugins when the selection in a relevant view has changed, using the same debouncing that is used for
textDocument/documentHighlightandtextDocument/codeActionrequests.Closes #2655