-
Notifications
You must be signed in to change notification settings - Fork 188
revert limiting semantic highlight to one session #2711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
If multiple sessions for semantic highlighting should really be allowed, then the show scope name command should probably check all LSP/plugin/semantic_highlighting.py Line 61 in 9bfb68d
|
plugin/semantic_highlighting.py
Outdated
|
|
||
| semantic_tokens_html = '' | ||
| for info in semantic_info: | ||
| semantic_tokens_html += f'<div>Type: {info[0]}, Modifiers: {info[1]} <a>{info[2]}</a></div>' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why is there a link (a tag) for the session name, and without any link destination? I think it would be better to change this maybe using a dimmed color instead, like the syntax name which is displayed in the ST references popup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jwortmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not super happy with this approach to render tokens from all sessions at the same time. But I guess if desired we can opt-out with disabled_capabilities, while it would not be possible to opt-in with multiple sessions and the current code. So let's revert then.


Revert semantic-highlighting specific part of #2688 since it breaks highlighting in Vue files.