Feature/446 comment post saves #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the CommentSave table and replaced it with a more generic LinkPersonComment table. Adjustments were also made to associated event classes, services, and repositories. Moreover, renamed the CommentSave entity to LinkPersonComment in the database and added a new link_type column. This change allows additional person-comment link types to be handled in the future beyond just saving comments. Signed-off-by: rooki <rooki@rooki.xyz>
CommentSave and PostSave Services, events, and related entities have been refactored and renamed to reflect better usage of "Link" concept. This includes renaming "CommentSaveService" to "LinkPersonCommentService" and "PostSaveService" to "LinkPersonPostService". Functions within these services have also been restructured and properly re-implemented to adhere to new service contracts. Signed-off-by: rooki <rooki@rooki.xyz>
The LinkPersonPostRepository has been moved from the post/repositories directory to person/repositories and associated methods have been updated accordingly. The PostController class has been refactored to handle post links instead of post saves. The LemmyPostService now calculates unread comments based on comment reads and removed state, and updates associated in the PostView model. Other minor changes include code cleanup in LemmyPostReportService and correcting imports in various classes. Signed-off-by: rooki <rooki@rooki.xyz>
The code formatting in the ExpiredRoleScheduler class has been tidied up for better readability. The warning message when the default role is not found has also been updated to indicate that this is expected during the initial application start-up. Signed-off-by: rooki <rooki@rooki.xyz>
…ure/446-comment-post-saves # Conflicts: # src/main/java/com/sublinks/sublinksapi/api/lemmy/v3/post/services/LemmyPostService.java # src/main/resources/db/migration/V20231003__Create_initial_entity_tables.sql # src/main/resources/db/migration/V20231006__Create_foreign_key_references.sql
Refactored link management methods across various services to use streamlined logic and improved consistency. Enhanced database schema with new indices, added support for link events, and optimized persistence calls. Signed-off-by: rooki <rooki@rooki.xyz>
…ure/446-comment-post-saves
…ure/446-comment-post-saves # Conflicts: # src/main/java/com/sublinks/sublinksapi/api/lemmy/v3/community/controllers/CommunityController.java
Switched method arguments and refactored linking logic in multiple services for consistency and improved clarity. Added new deleteLink implementations, adjusted method calls, and updated entity mapping for better maintainability. Signed-off-by: rooki <rooki@rooki.xyz>
…mmentService` Simplify line formatting for conversion calls and improve readability. Added conditional checks to prevent redundant link checks when the creator is an admin or banned in `LemmyCommentService`. Signed-off-by: rooki <rooki@rooki.xyz>
Refactor method to check link between community and person for moderator/owner roles. Improve annotations formatting in controllers to enhance readability. Remove unused repository fields in LemmyCommentService. Signed-off-by: rooki <rooki@rooki.xyz>
Standardize the HttpStatus.UNAUTHORIZED error messages across multiple controllers by changing specific messages like "not_an_admin" and "not_allowed" to a uniform "unauthorized" message. This enhances consistency and simplifies maintenance of error responses. Signed-off-by: rooki <rooki@rooki.xyz>
Improves link management across various services by introducing refresh methods to handle EntityManager updates. Simplifies existing methods and ensures data consistency through immediate persistence and state refresh operations. Signed-off-by: rooki <rooki@rooki.xyz>
Refactored multiple services and repositories to improve code readability and maintainability including formatting for better line breaks. Replaced deprecated refresh logic with streamlined data handling and enhanced method signatures for better context. Signed-off-by: rooki <rooki@rooki.xyz>
Refactored `getPersonPosts` and `getPersonComments` methods to use detailed search criteria. Introduced a `setSavedOnly` method in `PostSearchQueryService` and created `CommentSortTypeSortMapper` for better sorting flexibility. Signed-off-by: rooki <rooki@rooki.xyz>
lazyguru
requested changes
Aug 3, 2024
Member
lazyguru
left a comment
lazyguru
left a comment
There was a problem hiding this comment.
I left some comments, please push back if there are good reasons for keeping the code the way it is.
|
|
||
| logger.warning("Default registered role not found."); | ||
| logger.warning( | ||
| "Default registered role not found. (Expected if it is your initial start of the application.)"); |
Member
There was a problem hiding this comment.
Is there not a way to detect this?
Member
Author
There was a problem hiding this comment.
Not really without having another table that has something in it.
src/main/java/com/sublinks/sublinksapi/comment/repositories/CommentReadRepository.java
Outdated
Show resolved
Hide resolved
| public interface LinkPersonCommentRepository extends JpaRepository<LinkPersonComment, Long> { | ||
|
|
||
|
|
||
| Optional<LinkPersonComment> getLinkPersonCommentByCommentAndPersonAndLinkType(Comment comment, |
Member
There was a problem hiding this comment.
I forget that Java supports method overloading. Do we really need to have all of these methods have different names? Why not just have getLinkPersonComment and multiple different signatures?
Member
Author
There was a problem hiding this comment.
Because this is jpa? Or i could of course make custom query with @query but then we will have to do this on every other repository too.
src/main/java/com/sublinks/sublinksapi/person/services/LinkPersonCommunityService.java
Show resolved
Hide resolved
Replaced method definition with a JPQL query to count comments by person, post, and removed state. Updated the LemmyPostService to call the refactored repository method. Signed-off-by: rooki <rooki@rooki.xyz>
lazyguru
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #446