Remove leading $ char from copy blocks #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LauraLangdon
changed the title
Contributor
hola-soy-milk
left a comment
hola-soy-milk
left a comment
There was a problem hiding this comment.
Thanks @LauraLangdon! One thing I noticed is that this PR does a number of things, like rename "Editor" to "Session" and rename files.
Just wanted to double-check that this is intended too? Shall we rename the PR?
Contributor
Author
|
Oops, forgot to change the branch to be merged into! It should be the beta docs one, which already has those other changes. I'll fix that. Thanks! |
hola-soy-milk
approved these changes
Apr 18, 2023
Contributor
hola-soy-milk
left a comment
hola-soy-milk
left a comment
There was a problem hiding this comment.
Thanks for clarifying, looks great! ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's annoying to have to delete the leading
$character from a block you're supposed to be able to just hit the 'copy' button on, so we should take them out.E.g. here: https://beta.docs.suborbital.dev/quickstart#using-the-se2-sdk