-
Notifications
You must be signed in to change notification settings - Fork 5
Runtime API for JS&TS using the multi-language tabbed code block component #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hola-soy-milk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So excited for this! Some minor questions and recommendations
|
This latest change adds support for a few extra features that made it possible to include docs for JS/TS, as demonstrated in the HTTP API, with the remaining APIs coming soon. I have also filed #59 to make note of some of the recently added but as-of-yet undocumented API features. |
|
The latest changes document the remaining Runtime API imports for JavaScript and TypeScript. I have included various clarifications in the other docs as I transformed the files to use the I have filed a variety of follow-up issues on Reactr for bugs, missing implementations and other inconsistencies:
|
hola-soy-milk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
I noticed some code blocks that are preceded by explanations about AssemblyScript but are noted as a typescript code block.
Could it be these need adapting?
99ef9d9 to
0d6425a
Compare
|
I rebased this on the recent GH Actions changes which means previews of this PR now deploy under: |
|
Let's change JS/TS to |
Yeah so the reason for this is that if you selected a language somewhere it "syncs" across the fields, but if that language is not available another tab is not selected automatically. There is a "default tab" option but I haven't been able to figure out how to make it work just yet, can file a followup though because I agree that until we have 100% coverage for all languages this can be a bit jarring. |
cohix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The quirk with the language picker is understood and shouldn't block this PR! Let's get it merged.
|
Created #73 to track the default-language-tab issue, and I'm going to merge this. |

Work-in-progress multi-language code block component ( #27 ) to address various issues around Runtime API, maintenance and API documentation quality.
Currently all code lives on the
atmo/runnable-api/introduction.mdpage as a proof of concept, and it will need to be moved out to its own component. Similarly the configuration object for language support stability ( #32 ) will need to move to its own config JSON. Language stability now has its own page to be referenced from everywhere in the Reactr component.Outstanding work (may or may not be tackled as part of this PR):
<div>-s to allow adding extra content to some of the tabs