Merged
Conversation
vbarua
reviewed
Dec 2, 2025
vbarua
approved these changes
Dec 2, 2025
Member
vbarua
left a comment
vbarua
left a comment
There was a problem hiding this comment.
Keeping the meaning of project inline with the general Substrait expectation seems super reasonable to me.
I'd be pretty happy to merge this PR as, but what do you think about adding a docstring to select and project to indicate what they do? I'm trying to be better about having use document APIs as we add them 😅
When we merge this, we should also mark this as a breaking change. I suspect that you're the primary, if not only, user of this builder API at this point, but it would be good to call it out anyway so we don't suprise anyone.
Member
|
Fixes #124 |
vbarua
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project builder in plan.py now builds a plan that outputs all inputs field
followed by all expressions.
The select builders captures the old behavior of project and outputs only the
expressions.
BREAKING CHANGE: the project builder in plan.py has been renamed to select