Separate the Reporting of 'bearing' vs. 'heading.

[mikeller]

There seems to be two different ways that dive computers report
directional information:

1. report headings that are set by the user by pointing the device in
   the desired direction, then pressing a button;

2. report the direction that the device is pointing in at set intervals
   (like every 10 seconds) during the dive.

For a user-friendly visualisation, these two approaches need to be shown
in different ways in Subsurface:

1. show an event in the profile every time the user executes the 'set
   heading' operation (and potentially at the start of the dive for the
   initial heading):

2. show the current bearing in the information box in the profile when
   the mouse pointer traverses the profile:

Subsurface will be using different ways for libdivecomputer backends to
import this data:

1. using DC_SAMPLE_EVENT samples with SAMPLE_EVENT_HEADING type;

2. using DC_SAMPLE_BEARING samples.

This changeset updates the following dive computers to use 1. to match
their type of reporting:

• Heinrichs Weikamp OSTC3 / 4 / 5
• ScubaPro / Uwatec Smart

The following dive computers are already using 1. correctly:

• Suunto EON Steel
• Suunto D9

And the following dive computer seems to be using 2. correctly:

• Divesoft Freedom / Liberty (@jakubhecko are you able to confirm this?)

The following dive computers are currently using 2., but we don't have
any information if this is correct:

• DiveSystem iDive
• Shearwater Predator
• Halcyon Symbios

Signed-off-by: Michael Keller github@ike.ch

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[dirkhh]

looks reasonable

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Variable shadowing issue: declaring a new local variable 'sample' here shadows the outer 'sample' variable declared at line 928. This causes the 'event.time' and 'event.name' fields to not be initialized (defaulting to 0 and NULL respectively). Consider using the outer 'sample' variable instead, similar to how the bookmark event is handled at lines 1167-1172. The event.time field should be set to 0 to match the bookmark handling pattern.

Suggested change

	dc_sample_value_t sample = {
	.event.type = SAMPLE_EVENT_HEADING,
	.event.flags = SAMPLE_FLAGS_SEVERITY_INFO,
	.event.value = bearing,
	};
	sample.event.type = SAMPLE_EVENT_HEADING;
	sample.event.time = 0;
	sample.event.flags = SAMPLE_FLAGS_SEVERITY_INFO;
	sample.event.value = bearing;
	sample.event.name = NULL;

[Copilot]

Inconsistent spacing: this callback invocation is missing a space before the opening parenthesis, unlike other callback invocations in this function (e.g., lines 1149, 1158, 1164, 1172, 1177, 1185, 1191, 1207).

Suggested change

	if (callback) callback(DC_SAMPLE_EVENT, &sample, userdata);
	if (callback) callback (DC_SAMPLE_EVENT, &sample, userdata);

[Copilot]

Inconsistent spacing: this callback invocation is missing a space before the opening parenthesis, unlike most other callback invocations in this function (e.g., lines 984, 991, 997, 1003, 1009, 1068, 1102, etc.).

Suggested change

	callback(DC_SAMPLE_EVENT, &sample, userdata);
	callback (DC_SAMPLE_EVENT, &sample, userdata);