Skip to content

Conversation

@dirkhh
Copy link
Collaborator

@dirkhh dirkhh commented Dec 5, 2024

The treadmill never stops.

Describe the pull request:

  • Build system change

Pull request long description:

I doubt it will be this easy. It never is. But let's give it a try.

@github-actions
Copy link

github-actions bot commented Dec 5, 2024

Artifacts:
Subsurface-Windows-6.0.5296-patch.1.pull-request.android34
WARNING: Use at your own risk.

@github-actions
Copy link

github-actions bot commented Dec 5, 2024

Artifacts:
Subsurface-Android-6.0.5296-patch.1.pull-request.android34
WARNING: Use at your own risk.

@github-actions
Copy link

github-actions bot commented Dec 5, 2024

Artifacts:
Subsurface-Windows-6.0.5296-patch.1.pull-request.android34
WARNING: Use at your own risk.

@github-actions
Copy link

github-actions bot commented Dec 5, 2024

Artifacts:
Subsurface-Android-6.0.5296-patch.1.pull-request.android34
WARNING: Use at your own risk.

@github-actions
Copy link

github-actions bot commented Dec 5, 2024

Artifacts:
Subsurface-Windows-6.0.5296-patch.2.pull-request.android34
WARNING: Use at your own risk.

@mikeller
Copy link
Member

mikeller commented Dec 5, 2024

I saw #3979 (comment) - but I am not 100% convinced that the SDK warning isn't just a red herring, and this doesn't work because some form of device lockdown.

@matasbbb can you please test with the android artifact in this pull request to confirm that this can be installed on your phone.

@dirkhh
Copy link
Collaborator Author

dirkhh commented Dec 5, 2024

I saw #3979 (comment) - but I am not 100% convinced that the SDK warning isn't just a red herring, and this doesn't work because some form of device lockdown.

@matasbbb can you please test with the android artifact in this pull request to confirm that this can be installed on your phone.

@mikeller I can reproduce it here. You need to uninstall the existing app and try to install it fresh in order to see it. Depending on "some stuff" (don't ask me) it appears that updates still work, it's just new installs that fail.

I'm now on round four of trying to track down what it takes to get this sorted. I absolutely love how well Google treats its developers.

Oh, btw - if you are on Android 15 you now get a super obnoxious popup when side-loading an app that requires you to find a hidden option in order to actually install the app... and here I thought abandoning the store would protect us from most of Google's shenanigans. Not so much, it seems.

@dirkhh
Copy link
Collaborator Author

dirkhh commented Dec 5, 2024

Hmm. now I'm even more confused. On a different phone on Android 15, I CAN side load the "current" build of Subsurface. I get a different warning about lacking privacy, etc, but after finding the hidden option it does appear to install successfully and work.
This is all not great, as far as I'm concerned.

@github-actions
Copy link

github-actions bot commented Dec 5, 2024

Artifacts:
Subsurface-Windows-6.0.5296-patch.2.pull-request.android34
WARNING: Use at your own risk.

@github-actions
Copy link

github-actions bot commented Dec 6, 2024

Artifacts:
Subsurface-Windows-6.0.5296-patch.2.pull-request.android34
WARNING: Use at your own risk.

@github-actions
Copy link

github-actions bot commented Dec 6, 2024

Artifacts:
Subsurface-Windows-6.0.5296-patch.2.pull-request.android34
WARNING: Use at your own risk.

@github-actions
Copy link

github-actions bot commented Dec 6, 2024

Artifacts:
Subsurface-Windows-6.0.5296-patch.2.pull-request.android34
WARNING: Use at your own risk.

@github-actions
Copy link

github-actions bot commented Dec 6, 2024

Artifacts:
Subsurface-Windows-6.0.5296-patch.2.pull-request.android34
WARNING: Use at your own risk.

@github-actions
Copy link

github-actions bot commented Dec 6, 2024

Artifacts:
Subsurface-Windows-6.0.5296-patch.2.pull-request.android34
WARNING: Use at your own risk.

@github-actions
Copy link

Artifacts:
Subsurface-Windows-6.0.5299-patch.1.pull-request.android34
WARNING: Use at your own risk.

@github-actions
Copy link

Artifacts:
Subsurface-MacOS-6.0.5299-patch.1.pull-request.android34
WARNING: Use at your own risk.

@github-actions
Copy link

This pull request has merge conflicts, please resolve them in order to make this pull request ready for review / merge.

@mikeller
Copy link
Member

@dirkhh: I think this will become more and more valuable / urgent over time - do you have motivation / capacity to have another stab at it?

@dirkhh
Copy link
Collaborator Author

dirkhh commented Apr 30, 2025

Not for several weeks.

The treadmill never stops.
Apparently when switching to a newer SDK, we also need to add a new pointless
value to the activity section.

Android: add pointless receive exported flag

Because why make backwards compatible changes to the SDK when you can instead
break existing applications for absolutely no reason...

And of course the new required parameter doesn't exist in the older SDK we used
to use, so the forced change also forces us to abandon older Android versions.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Signed-off-by: Subsurface CI <ci@subsurface-divelog.org>
@github-actions
Copy link

Thank you for resolving the merge conflicts.

@github-actions
Copy link

Artifacts:
Subsurface-Linux-AppImage-6.0.5386-patch.1.pull-request.android34
WARNING: Use at your own risk.

@github-actions
Copy link

Artifacts:
Subsurface-Windows-6.0.5386-patch.1.pull-request.android34
WARNING: Use at your own risk.

@github-actions
Copy link

Artifacts:
Subsurface-MacOS-6.0.5386-patch.1.pull-request.android34
WARNING: Use at your own risk.

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

This pull request has merge conflicts, please resolve them in order to make this pull request ready for review / merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants