-
-
Notifications
You must be signed in to change notification settings - Fork 564
Android: bump target SDK Version to 35 #4391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Artifacts: |
|
Artifacts: |
|
Artifacts: |
|
Artifacts: |
|
Artifacts: |
|
I saw #3979 (comment) - but I am not 100% convinced that the SDK warning isn't just a red herring, and this doesn't work because some form of device lockdown. @matasbbb can you please test with the android artifact in this pull request to confirm that this can be installed on your phone. |
@mikeller I can reproduce it here. You need to uninstall the existing app and try to install it fresh in order to see it. Depending on "some stuff" (don't ask me) it appears that updates still work, it's just new installs that fail. I'm now on round four of trying to track down what it takes to get this sorted. I absolutely love how well Google treats its developers. Oh, btw - if you are on Android 15 you now get a super obnoxious popup when side-loading an app that requires you to find a hidden option in order to actually install the app... and here I thought abandoning the store would protect us from most of Google's shenanigans. Not so much, it seems. |
|
Hmm. now I'm even more confused. On a different phone on Android 15, I CAN side load the "current" build of Subsurface. I get a different warning about lacking privacy, etc, but after finding the hidden option it does appear to install successfully and work. |
|
Artifacts: |
|
Artifacts: |
|
Artifacts: |
|
Artifacts: |
|
Artifacts: |
|
Artifacts: |
|
Artifacts: |
|
Artifacts: |
|
This pull request has merge conflicts, please resolve them in order to make this pull request ready for review / merge. |
|
@dirkhh: I think this will become more and more valuable / urgent over time - do you have motivation / capacity to have another stab at it? |
|
Not for several weeks. |
The treadmill never stops. Apparently when switching to a newer SDK, we also need to add a new pointless value to the activity section. Android: add pointless receive exported flag Because why make backwards compatible changes to the SDK when you can instead break existing applications for absolutely no reason... And of course the new required parameter doesn't exist in the older SDK we used to use, so the forced change also forces us to abandon older Android versions. Signed-off-by: Dirk Hohndel <dirk@hohndel.org> Signed-off-by: Subsurface CI <ci@subsurface-divelog.org>
|
Thank you for resolving the merge conflicts. |
|
Artifacts: |
|
Artifacts: |
|
Artifacts: |
|
This pull request has merge conflicts, please resolve them in order to make this pull request ready for review / merge. |
The treadmill never stops.
Describe the pull request:
Pull request long description:
I doubt it will be this easy. It never is. But let's give it a try.