added basic 7 inch crowpanel support#167
Open
JulianStremel wants to merge 1 commit intosuchmememanyskill:masterfrom
Open
added basic 7 inch crowpanel support#167JulianStremel wants to merge 1 commit intosuchmememanyskill:masterfrom
JulianStremel wants to merge 1 commit intosuchmememanyskill:masterfrom
Conversation
suchmememanyskill
requested changes
Mar 15, 2025
Owner
suchmememanyskill
left a comment
suchmememanyskill
left a comment
There was a problem hiding this comment.
You seem to be missing a board .json, also
| /*Set the coordinates*/ | ||
| data->point.x = touch_last_x; | ||
| data->point.y = touch_last_y; | ||
| //Serial.print( "Data x " ); |
There was a problem hiding this comment.
Would you mind removing commented out code? (I know the original driver has this too. If you feel like it, could you remove it there too?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it says in the title...
I also would like to build a custom ui that resembles klipper screen more closely i also need to get the sdcard to work for external assets but i do not know if any oft this project takes advantage of an external storage medium.