UofT-DSI | Unix Shell, Git & GitHub - Assignment 1#1
Open
sullivanlisa wants to merge 5 commits intomainfrom
Open
UofT-DSI | Unix Shell, Git & GitHub - Assignment 1#1sullivanlisa wants to merge 5 commits intomainfrom
sullivanlisa wants to merge 5 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Add code to create a data folder, move raw data to it, sort data by log type, remove IP address data and list sorted files in a text file.
What did you learn from the changes you have made?
How to use a bash script to mange files
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I would have liked to have recursively delete the ip address files, but that didn't seem to work
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I had some challenged with pushing and creating pull requests, but I was able to reverse my changes and try again
How were these changes tested?
In creating the test, I tested each line one at a time to ensure it worked, checking that files were moved/deleted/listed as intended. I then deleted the folder and ran the whole script to ensure it functioned as intended
A reference to a related issue in your repository (if applicable)
Checklist