Add num_workers to BaseDataset #743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Logiquo
added
component: dataset
jhnwu3
reviewed
Dec 18, 2025
| n_workers=self.num_workers, | ||
| threads_per_worker=1, | ||
| processes=False, | ||
| processes=not in_notebook(), |
Collaborator
There was a problem hiding this comment.
Just curious, why do we need to check if we're in a jupyter notebook or not?
Collaborator
Author
There was a problem hiding this comment.
jupyter notebook is a bit tricky when dealing with multiprocessing (due to the natural of Python). So we would typically prefer to not use it when possible.
e.g. main guard in the cell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor: Yongda Fan (yongdaf2@illinois.edu)
Contribution Type: Dataset
Description
Support configure
n_workersfor dask cluster.Files to Review
pyhealth/datasets/base_dataset.py