Fix MIMIC3 unit tests #757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
any particular reason we want to rename .csv.gz file to UPPER CASE? e.g. ADMISSIONS.csv.gz |
EricSchrock
commented
Dec 28, 2025
Collaborator
Author
There was a problem hiding this comment.
This file needs to exist since MIMIC3Dataset always loads the icustays table. However, I only included the header row, as actual data isn't needed to pass the tests.
subject_id,intime,icustay_id,first_careunit,dbsource,last_careunit,outtime
Collaborator
Author
@Logiquo |
Logiquo
approved these changes
Dec 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on updating #751 to use
test-resources/core/mimic3demo, I noticed that the MIMIC3 unit tests were being skipped because the path tomimic3demowas wrong. It looks like this has been broken since #607 so a few other issues have crept into the MIMIC3 unit tests that needed to be patched up.