This repository was archived by the owner on Jul 16, 2024. It is now read-only.
Updated code to support macOS versions earlier than 10.12 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.) mapping NSImageLeading and NSImageTrailing image positions to NSImageLeft and NSImageRight respectively when run on macOS 10.12 but ignore these values otherwise. 2.) assumes imageHugsTitle == NO on macOS < 10.12. This property was added in 10.12 and the default value is NO.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated code to support macOS versions earlier than 10.12 by:
1.) mapping NSImageLeading and NSImageTrailing image positions to NSImageLeft and NSImageRight respectively when run on macOS 10.12 but ignore these values otherwise.
2.) assumes imageHugsTitle == NO on macOS < 10.12. This property was added in 10.12 and the default value is NO - so it's save to assume this behavior for earlier versions of macOS.